Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional testing package #6013

Closed
mconnelly8 opened this issue Apr 13, 2023 · 2 comments
Closed

Add additional testing package #6013

mconnelly8 opened this issue Apr 13, 2023 · 2 comments
Assignees
Labels
4.x 4.0 related

Comments

@mconnelly8
Copy link

transactions.json.gz testing package

@mconnelly8 mconnelly8 added the 4.x 4.0 related label Apr 13, 2023
@jdevcs jdevcs self-assigned this May 3, 2023
@jdevcs
Copy link
Contributor

jdevcs commented May 5, 2023

As shared in team meeting:
I imported transactions.json file with transactions test cases

  • and there were list of tests that were not passing validation ( missing to, missing gas etc ) fields so these test cases were removed ( as if I include missing fields it was changing output raw tx )

Following two bugs / discussion items are discovered :

@jdevcs
Copy link
Contributor

jdevcs commented May 8, 2023

transactions.json file is used from ethers repo for testing web3 4.x tx.

  • Only transactions with:
    to, nonce, gasPrice, gasLimit or
    to, nonce, maxFeePerGas, maxPriorityFeePerGas, gasLimit fields
    are used for testing in this PR.

  • Some Transactions with gasPrice 0x4617ee7c40 has error :

"Eip1559GasPriceError: Invalid value given \"0x4617ee7c40\". Error: eip-1559 transactions don't support gasPrice." #6065 These txs data is excluded in this PR, it should be investigated under 6065.

@jdevcs jdevcs closed this as completed May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

No branches or pull requests

2 participants