Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist only lib for files entry in package.jsons #5743

Closed
spacesailor24 opened this issue Jan 10, 2023 · 3 comments
Closed

Whitelist only lib for files entry in package.jsons #5743

spacesailor24 opened this issue Jan 10, 2023 · 3 comments
Assignees
Labels
4.x 4.0 related

Comments

@spacesailor24
Copy link
Contributor

    For npm whitelisting only `lib` , this will filter out `dist` form including in published lib. 

This will impact CDN as current CDN is configured to pick minified build through npm ( as per Greg info, I discussed with him last time ).

I personally like it, as it will reduce lib size , so users node_modules will be of less size ( by excluding minified builds) but we will need to configure explicitly CDN for 4.x.

Originally posted by @jdevcs in #5739 (comment)

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Mar 12, 2023
@jdevcs jdevcs removed the Stale Has not received enough activity label Mar 13, 2023
@jdevcs jdevcs self-assigned this May 31, 2023
@jdevcs jdevcs mentioned this issue May 31, 2023
17 tasks
@jdevcs
Copy link
Contributor

jdevcs commented May 31, 2023

until we have same CDN structure, we will need to whitelist dist as well so its not filtered, fix posted in above PR.

@jdevcs
Copy link
Contributor

jdevcs commented May 31, 2023

related: #6037

@jdevcs jdevcs closed this as completed May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

No branches or pull requests

2 participants