Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rewrite 4.x] Eth Transaction #4320

Closed
4 of 16 tasks
jdevcs opened this issue Sep 13, 2021 · 3 comments
Closed
4 of 16 tasks

[Rewrite 4.x] Eth Transaction #4320

jdevcs opened this issue Sep 13, 2021 · 3 comments
Assignees
@spacesailor24
Labels
4.x 4.0 related Epic Stale Has not received enough activity

Comments

@jdevcs
Copy link
Contributor

jdevcs commented Sep 13, 2021 •
edited by spacesailor24
Loading

( This is Epic for 4.x Management )

Transaction

Supports sending Transaction.
Validate Transaction.
Fill default values if requested by user.

TODOs

Nice to Haves

  • accessListify
  • parseTransaction
    • This could be implemented as a standalone method, but creating a transaction object should support serialized transactions for instantiation
  • serializeTransaction
    • This could probably be achieved by exposing a serialize method from @ethereumjs/tx object

Dependencies / Related Modules

Providers
Web3 Eth
Wallet / Accounts

Documentation

  • README ( overview, example, .. )
  • Documentation

Tests

Goal: >80% Coverage

  • unit tests
  • integration tests
  • e2e tests

Related Issues / Feature Requests / Discussion

Related EIPs

https://eips.ethereum.org/EIPS/eip-2930
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1559.md

External Libs

Follow Lib Selection checklist.
@jdevcs jdevcs added 4.x 4.0 related Epic labels Sep 13, 2021
@philknows philknows changed the title [Rewrite 4.x] Transaction [Rewrite 4.x] eth-tx Oct 5, 2021
@philknows philknows mentioned this issue Oct 5, 2021
Closed
@jdevcs jdevcs mentioned this issue Oct 19, 2021
Closed
10 tasks
@jdevcs jdevcs changed the title [Rewrite 4.x] eth-tx [Rewrite 4.x] Eth Transaction Dec 14, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label May 19, 2022
@mconnelly8 mconnelly8 removed the Stale Has not received enough activity label May 24, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Jul 24, 2022
@jdevcs
Copy link
Contributor Author

jdevcs commented Jul 26, 2022

we included Eth Transaction as part of Eth package instead of dedicated Eth Tx package.

@jdevcs jdevcs closed this as completed Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spacesailor24 spacesailor24

Labels
4.x 4.0 related Epic Stale Has not received enough activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spacesailor24 @jdevcs @mconnelly8