Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write GH Actions "allowed failure" reporter #3503

Closed
cgewecke opened this issue May 6, 2020 · 2 comments · Fixed by #3530
Closed

Write GH Actions "allowed failure" reporter #3503

cgewecke opened this issue May 6, 2020 · 2 comments · Fixed by #3530
Assignees
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations

Comments

@cgewecke
Copy link
Collaborator

cgewecke commented May 6, 2020

There are 3 CI jobs marked continue-on-error which always pass.

Would be nice if there was an additional cue in the UI about whether they failed or not.

@cgewecke cgewecke added Enhancement Includes improvements or optimizations 1.x 1.0 related issues CI labels May 6, 2020
@cgewecke cgewecke self-assigned this May 6, 2020
@ryanio
Copy link
Collaborator

ryanio commented May 20, 2020

one idea could be to split up the ci script into smaller steps so the continue-on-error property can be moved to only the part of the expected failure, so if it fails before that we will get a red x.

@cgewecke
Copy link
Collaborator Author

@ryanio We would get a red x but CI would allow merging? That's all that's necessary really...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants