Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ethers from the dependencies #3484

Closed
alcuadrado opened this issue Apr 23, 2020 · 3 comments · Fixed by #3490
Closed

Removing ethers from the dependencies #3484

alcuadrado opened this issue Apr 23, 2020 · 3 comments · Fixed by #3490
Labels
1.x 1.0 related issues

Comments

@alcuadrado
Copy link

As we discussed yesterday, having ethers as a dependency in web3.js makes npm stats worthless, and we should remove it asap.

I'm inclined to vendor the part of ethers that web3 uses for now, as it's a low effort way of solving it, release a patch version, and then analyze if an ethers v5 package can be used.

As I already mentioned, keep in mind that a change like this one takes some time to manifest itself in the stats, so releasing soon is pretty important.

@ricmoo
Copy link
Contributor

ricmoo commented Apr 24, 2020

The package you will be interested in is @ethersproject/abi. There may be some issues revolving around invalid UTF-8 strings though. I can add a function similar to the coerceFunc to handle errors, so that errors can be recovered from, since I think web3 lets invalid data through. I'll tinker with ideas for this API.

@cgewecke cgewecke added 1.x 1.0 related issues dependencies labels Apr 24, 2020
@cgewecke
Copy link
Collaborator

cf: #3461 / #3441 / #1610

@ricmoo
Copy link
Contributor

ricmoo commented Apr 25, 2020

For discussion on the ABI Coder and possible solutions: ethers-io/ethers.js#800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants