Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong AbiInput type #3270

Closed
ilanolkies opened this issue Dec 11, 2019 · 1 comment · Fixed by #3279
Closed

Wrong AbiInput type #3270

ilanolkies opened this issue Dec 11, 2019 · 1 comment · Fixed by #3279
Labels
1.x 1.0 related issues Types Incorrect or missing types

Comments

@ilanolkies
Copy link

https://github.com/ethereum/web3.js/blob/39220467f4a10de511bb0e7b024fc37c9f92a7d5/packages/web3-utils/types/index.d.ts#L225

Now Truffle is adding internalType: "..." in build. For example:

const STR_ABI = [
  {
    constant: true,
    inputs: [
      { internalType: "bytes32", name: "node", type: "bytes32" }
    ],
    name: "str",
    outputs: [
      { internalType: "string", name: "", type: "string" }
    ],
    payable: false,
    stateMutability: "view",
    type: "function"
  }
];
@ilanolkies ilanolkies changed the title Wrong type Wrong AddrInput type Dec 11, 2019
@ilanolkies ilanolkies changed the title Wrong AddrInput type Wrong AbiInput type Dec 11, 2019
@nivida nivida added 1.x 1.0 related issues Types Incorrect or missing types labels Dec 12, 2019
@nivida
Copy link
Contributor

nivida commented Dec 12, 2019

Thanks for opening this issue! We will improve the referenced type definition asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Types Incorrect or missing types
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants