Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter documentation brings confusion #3103

Closed
watchcrypto opened this issue Oct 6, 2019 · 3 comments
Closed

Parameter documentation brings confusion #3103

watchcrypto opened this issue Oct 6, 2019 · 3 comments
Labels
1.x 1.0 related issues 2.x 2.0 related issues Documentation Relates to project wiki or documentation

Comments

@watchcrypto
Copy link

watchcrypto commented Oct 6, 2019

Description

As i needed to use some method to verify ( recover? ) a signed message, i did a lot of research and what came out of it is that apparently a lot of people ( mostly stackexchange ) reffer to a method that is rather complicated AKA : web3.eth.accounts.recover(signatureObject);

As i am working with Ethereum technologies since a long time, i know that it is really easy to implement.

By checking through the different help topics i even found a guy advising to use a smart contract to do this, which is a total overkill and useless waste of time.

NB: i am not frustrated, i just prefer when things are clear. http://threevirtues.com/ virtue n1

Expected behavior

The parameter description should be clear, especially in the OR part.

Actual behavior

Miss guiding description who leads a real burden and useless waste of time.
The paramater can be of 2 different types while only 1 is explicitly verbosed.

Steps to reproduce the behavior

1- Think as a newbie, or someone with a limited tech knowledge
2- check pages like :
https://ethereum.stackexchange.com/questions/13652/how-do-you-sign-an-verify-a-message-in-javascript-proving-you-own-an-ethereum-ad?newreg=bc39e02bca304017bbc18739638894d0

or

use these keywords in google ( preferably in private mode ) : ethereum verify signed message js
3- look at this : https://web3js.readthedocs.io/en/v1.2.0/web3-eth-accounts.html#recover
First thing you will see is the red text, for sure. And as the other docs to point to a comre complicated parameters setup you jump straight to it.

Error Logs

MyBrainIsBurning.log

Gists

Obviously not required for this issue.

Versions

  • web3.js: n/a
  • nodejs: n/a
  • browser: Firefox@latest
  • ethereum node: n/a
@cgewecke cgewecke added the Documentation Relates to project wiki or documentation label Oct 7, 2019
@nivida nivida added 1.x 1.0 related issues 2.x 2.0 related issues labels Oct 8, 2019
@watchcrypto
Copy link
Author

It's been a week, it just asks for 1 minute of time to fix this.
If the team agrees i will make it myself.

@cgewecke
Copy link
Collaborator

@watchcrypto There has been some recent work on this topic in the following places:

Could you describe the additional changes you'd like to see in more detail?

@watchcrypto
Copy link
Author

Thanks a lot, now it is a lot more straight forward 👍
I close the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues 2.x 2.0 related issues Documentation Relates to project wiki or documentation
Projects
None yet
Development

No branches or pull requests

3 participants