Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meteor-specific require prevents static extraction #289

Closed
caktux opened this issue Aug 9, 2015 · 3 comments
Closed

Meteor-specific require prevents static extraction #289

caktux opened this issue Aug 9, 2015 · 3 comments
Labels
Bug Addressing a bug

Comments

@caktux
Copy link
Contributor

caktux commented Aug 9, 2015 

WARNING in ./~/web3/lib/web3/httpprovider.js
Critical dependencies:
28:84-91 require function is used in a way in which dependencies cannot be statically extracted
 @ ./~/web3/lib/web3/httpprovider.js 28:84-91
@caktux caktux added the Bug Addressing a bug label Aug 9, 2015
@caktux
Copy link
Contributor Author

caktux commented Aug 9, 2015

Changes in #284 fix this, please rebase, merge and publish a new version; been stuck on 0.8.1 since there hasn't been a single release that wasn't broken since then.

@debris
Copy link
Contributor

debris commented Aug 10, 2015

fixed in 0.12.1

@debris debris closed this as completed Aug 10, 2015
@caktux
Copy link
Contributor Author

caktux commented Aug 10, 2015

Indeed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caktux @debris