Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sha3 to keccak256 #2707

Closed
1 task done
princesinha19 opened this issue Apr 18, 2019 · 0 comments · Fixed by #2710
Closed
1 task done

Rename sha3 to keccak256 #2707

princesinha19 opened this issue Apr 18, 2019 · 0 comments · Fixed by #2710
Labels
Enhancement Includes improvements or optimizations

Comments

@princesinha19
Copy link
Contributor

princesinha19 commented Apr 18, 2019

As per EIP56, I think we should rename sha3 to keccak256.
https://web3js.readthedocs.io/en/1.0/web3-utils.html?highlight=sha3#sha3

We can still put sha3, an alias of keccak256 if someone wants.

  • Enhancement
@princesinha19 princesinha19 changed the title Rename sha3 to keccack256 Rename sha3 to keccak256 Apr 19, 2019
@nivida nivida added the Enhancement Includes improvements or optimizations label Apr 19, 2019
@nivida nivida mentioned this issue Apr 29, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants