-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reason string #1707
Comments
Any updates? |
Quick update, it should work, we are missing the implementation on Geth and Parity, but ganache-cli client (>= 6.1.3) has it, you can test it with truffle v5.0.0 |
Is this the reason there is no error message in the transaction data when using require? I have many requires with error messages, and when they fail I can't see anything in the transaction info on Etherscan about the reason. Remix shows the error when I use the JavaScript VM, but not on the test network. Is it true that the transaction information just doesn't have the error message yet when using require? |
Seems like it, Ganache and Remix VM have it, Geth or Partity, don't. |
This is a very nice feature. Will save time lot of time while debugging. |
@abhayks1 Yep, it is on my todo list and should get released in v1.0.0-beta.39 or -beta.40. |
Any updates? It seems that we are already at beta.41 |
A friendly ping, is error message handling still in the works? |
@GeeeCoin We do currently discuss the steps until the stable release here in this issue #2684 feel free to join the discussion! |
This issue should be removed from milestone Also, it should be moved from the |
But also, it's probably worth creating a parallel issue to add this into the stable |
How does this not have higher priority? This is so important. Every time one gets a Tx reverted with Web3 and doesn't know why, the only option is to comment out a single revert in the called method, re-deploy, get to the correct previous contract state again and see if it got reverted again. You can imagine what a pain this is for contracts with complex states and lots of reverts. |
For |
Any new status of this request? |
FYI the code Etherscan uses to get revert reasons is open source |
We have implemented this feature for 1.x and will release it on the next minor release. We will implement this feature also for 2.x and I'm closing this issue for now because we will anyways synchronize the existing features between 1.x and 2.x later. |
@nivida Do you have a rough estimate for when the minor release with this change might be ready? Thanks! |
It looks like this is the release to keep an eye on, right? |
@pcowgill Yep, it is and I will release it today. :) |
@nivida Does it work?
Am I using it correctly? |
@gorgos Yes, this is the currently expected behaviour for |
As an addition the workaround: |
According to Solidity 0.4.22 release, we can specify the reason in
revert
orrequire
function.After web3 1.0 alpha (or stable) version released, should plan to support reason string.
The text was updated successfully, but these errors were encountered: