Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from is mandatory for sendTransaction #124

Closed
jorisbontje opened this issue Mar 16, 2015 · 4 comments
Closed

from is mandatory for sendTransaction #124

jorisbontje opened this issue Mar 16, 2015 · 4 comments
Milestone
0.3.0

Comments

@jorisbontje
Copy link
Contributor

According to @fjl the from argument is mandatory for sendTransaction. If this is missing in the sendTransaction call I would expect an error. Probably also nice to indicate on https://github.com/ethereum/wiki/wiki/JavaScript-API which arguments are mandatory and which aint.

ethereum/go-ethereum#490 (comment)
@fjl
Copy link

fjl commented Mar 16, 2015

What is this issue about?

@jorisbontje
Copy link
Contributor Author

@fjl this issue is about from being mandatory for sendTransaction according to you. This currently isn't enforced by ethereum.js nor specified in the JS docs.

@SilentCicero
Copy link

Agreed, this is confusing and should be specified.

@debris debris added this to the 0.3.0 milestone Mar 30, 2015
@debris
Copy link
Contributor

debris commented Apr 2, 2015

I've updated the docs. from is mandatory for sendTransaction. Although implementations are allowed to be lenient.

@debris debris closed this as completed Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
4 participants
@fjl @jorisbontje @debris @SilentCicero