You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
currently in a lot of lines in the code the provider is checked whether is supports subscribe. This is done by simply checking, if the on-function exists
if(provider.on)
...
else
...
Since we also use different Wrappers, which even dynamically change the inner provider, this means, we must add and delete a function during runtime depending on the inner provider.
I would rather suggest a function supportsSubscription(). This would make it cleaner and easier to implement and even delegate this call to the inner wrapper.
if(provider.supportsSubscription())
...
else
...
The text was updated successfully, but these errors were encountered:
currently in a lot of lines in the code the provider is checked whether is supports subscribe. This is done by simply checking, if the
on
-function existsSince we also use different Wrappers, which even dynamically change the inner provider, this means, we must add and delete a function during runtime depending on the inner provider.
I would rather suggest a function
supportsSubscription()
. This would make it cleaner and easier to implement and even delegate this call to the inner wrapper.The text was updated successfully, but these errors were encountered: