Skip to content

Commit

Permalink
Revert CHANGELOG Changes from #7271 (#7274)
Browse files Browse the repository at this point in the history
  • Loading branch information
danforbes authored Sep 24, 2024
1 parent d6baee6 commit d45b712
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2724,7 +2724,7 @@ If there are any bugs, improvements, optimizations or any new feature proposal f

#### web3

- Return type for the static `Web3.requestEIP6963Providers` function is now `Promise<EIP6963ProviderResponse>`. (#7239)
- `Web3.providers` namespace exports `type EIP6963ProviderResponse = Map<string, EIP6963ProviderDetail>`. Return type for the static `Web3.requestEIP6963Providers` function is now `Promise<EIP6963ProviderResponse>`. (#7239)
- The callback function provided to the static `Web3.onNewProviderDiscovered` function expects a parameter of type `EIP6963ProvidersMapUpdateEvent` as opposed to `EIP6963AnnounceProviderEvent`. (#7242)

## [Unreleased]
2 changes: 1 addition & 1 deletion packages/web3/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ Documentation:

### Changed

- Return type for the static `Web3.requestEIP6963Providers` function is now `Promise<EIP6963ProviderResponse>`. (#7239)
- `Web3.providers` namespace exports `type EIP6963ProviderResponse = Map<string, EIP6963ProviderDetail>`. Return type for the static `Web3.requestEIP6963Providers` function is now `Promise<EIP6963ProviderResponse>`. (#7239)
- The callback function provided to the static `Web3.onNewProviderDiscovered` function expects a parameter of type `EIP6963ProvidersMapUpdateEvent` as opposed to `EIP6963AnnounceProviderEvent`. (#7242)

## [Unreleased]

1 comment on commit d45b712

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: d45b712 Previous: d6baee6 Ratio
processingTx 23420 ops/sec (±7.45%) 20672 ops/sec (±7.40%) 0.88
processingContractDeploy 39574 ops/sec (±7.28%) 39409 ops/sec (±5.84%) 1.00
processingContractMethodSend 16166 ops/sec (±7.54%) 14911 ops/sec (±8.22%) 0.92
processingContractMethodCall 27511 ops/sec (±7.79%) 26166 ops/sec (±9.05%) 0.95
abiEncode 44885 ops/sec (±6.94%) 41338 ops/sec (±7.20%) 0.92
abiDecode 30405 ops/sec (±7.00%) 29000 ops/sec (±6.11%) 0.95
sign 1567 ops/sec (±0.53%) 1518 ops/sec (±3.68%) 0.97
verify 369 ops/sec (±0.51%) 365 ops/sec (±0.65%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.