[BUGFIX] Return buttons if page is not callable #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ButtonBarHook seems to be called on root (pid=0) or other possible constellations, too. In these cases (and some other) the BackendUtility can't return avalid page record and returns null instead. Following up code didn't check, if a valid page record was loaded from the database, which lead to errors. WIth this commit, a check on a `$page === null` and hardening on possible not set array keys is added avoiding this issue
calien666
force-pushed
the
wv_deepltranslate-371
branch
from
bcce2e1
to
2ef7f75
Compare
sbuerk
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #371