Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host validation for 'sub' does not allow domains containing hyphen #94

Closed
ngdio opened this issue Apr 8, 2021 · 2 comments · Fixed by #96
Closed

Host validation for 'sub' does not allow domains containing hyphen #94

ngdio opened this issue Apr 8, 2021 · 2 comments · Fixed by #96

Comments

@ngdio
Copy link

ngdio commented Apr 8, 2021 •
edited
Loading

The host validation introduced in 871d67d does not allow domains that contain hyphens to pass through the check, although they should be perfectly valid domains.

Working: [email protected]

Not working: [email protected]

This is also causing the issue described in home-assistant/core#48766.
@wshuman3
Copy link

I believe the PR that introduced this was #92 not #91

@wshuman3 wshuman3 mentioned this issue Apr 15, 2021
Merged
@wshuman3
Copy link

#96 should resolve this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow hyphens in sub domains wshuman3/vapid
2 participants
@wshuman3 @ngdio