Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS: change userinfo tests due to URL parser changes #5121

Merged
merged 1 commit into from
Mar 27, 2017

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 13, 2017

In particular empty string password is now the same as not having a
password.

@wpt-pr-bot
Copy link
Collaborator

Notifying @hillbrad, @jdm, @odinho, and @zqzhang. (Learn how reviewing works.)

@ghost
Copy link

ghost commented Mar 13, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 15a68d9
Using browser at version BuildID 20170312110221; SourceStamp 3154da520af568d4da3de62bc26fbf97a1317f51
Starting 10 test iterations
All results were stable

All results

1 test ran
/cors/redirect-userinfo.htm
Subtest Results Messages
OK
Disallow redirect with userinfo (user:pass@) PASS
Disallow redirect with userinfo (user:@) PASS
Disallow redirect with userinfo (user@) PASS
Allow redirect without userinfo (:@ is trimmed during URL parsing) FAIL assert_unreached: Reached unreachable code
Disallow redirect with userinfo (:pass@) PASS
Allow redirect without userinfo (@ is trimmed during URL parsing) PASS

@ghost
Copy link

ghost commented Mar 13, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 15a68d9
Using browser at version 58.0.3029.14 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/cors/redirect-userinfo.htm
Subtest Results Messages
OK
Disallow redirect with userinfo (user:pass@) PASS
Disallow redirect with userinfo (user:@) PASS
Disallow redirect with userinfo (user@) PASS
Allow redirect without userinfo (:@ is trimmed during URL parsing) PASS
Disallow redirect with userinfo (:pass@) PASS
Allow redirect without userinfo (@ is trimmed during URL parsing) PASS

@annevk
Copy link
Member Author

annevk commented Mar 13, 2017

This makes Chrome pass all these tests. Firefox ends up failing one, but will pass that once it fixes its URL parser. WebKit: https://bugs.webkit.org/show_bug.cgi?id=169540.

In particular empty string password is now the same as not having a
password.
@annevk annevk force-pushed the annevk/cors-userinfo branch from 049655e to b8c26cb Compare March 13, 2017 12:15
@annevk annevk changed the title CORS: change user info due to URL parser changes CORS: change userinfo tests due to URL parser changes Mar 13, 2017
@annevk annevk requested a review from jgraham March 17, 2017 08:25
@annevk annevk requested a review from jdm March 27, 2017 16:14
@jdm jdm merged commit 0508311 into master Mar 27, 2017
@annevk annevk deleted the annevk/cors-userinfo branch March 27, 2017 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants