From dc8d5d401f85bb22e9d86a4e25abb92507edd28e Mon Sep 17 00:00:00 2001 From: James Craig Date: Mon, 21 Aug 2023 17:45:31 -0700 Subject: [PATCH 1/3] bypass bogus AOM crashtests that assume abaondoned API will be added. Closes https://github.com/web-platform-tests/interop-2023-accessibility-testing/issues/56 --- .../crashtests/aom-in-destroyed-iframe.html | 11 ++++++- ...ed-accessible-child-of-pseudo-element.html | 31 +++++++++++++------ .../computed-accessible-text-node.html | 25 ++++++++++----- .../crashtests/computed-node-checked.html | 12 +++++++ 4 files changed, 61 insertions(+), 18 deletions(-) diff --git a/accessibility/crashtests/aom-in-destroyed-iframe.html b/accessibility/crashtests/aom-in-destroyed-iframe.html index d412892983a48a..55f074d65c4c60 100644 --- a/accessibility/crashtests/aom-in-destroyed-iframe.html +++ b/accessibility/crashtests/aom-in-destroyed-iframe.html @@ -1,6 +1,11 @@ diff --git a/accessibility/crashtests/computed-accessible-child-of-pseudo-element.html b/accessibility/crashtests/computed-accessible-child-of-pseudo-element.html index 5bc1249907480d..f3f3680e44ddd5 100644 --- a/accessibility/crashtests/computed-accessible-child-of-pseudo-element.html +++ b/accessibility/crashtests/computed-accessible-child-of-pseudo-element.html @@ -6,17 +6,28 @@

Heading

diff --git a/accessibility/crashtests/computed-accessible-text-node.html b/accessibility/crashtests/computed-accessible-text-node.html index 29b7c2b2fe2d64..2028dd065e46c4 100644 --- a/accessibility/crashtests/computed-accessible-text-node.html +++ b/accessibility/crashtests/computed-accessible-text-node.html @@ -1,14 +1,25 @@ text diff --git a/accessibility/crashtests/computed-node-checked.html b/accessibility/crashtests/computed-node-checked.html index a413d26a019c11..ae570874adc795 100644 --- a/accessibility/crashtests/computed-node-checked.html +++ b/accessibility/crashtests/computed-node-checked.html @@ -19,6 +19,11 @@ From 5f7e0b9eeaf9c1b5ac48354a65431e40447788f7 Mon Sep 17 00:00:00 2001 From: James Craig Date: Tue, 22 Aug 2023 13:31:22 -0700 Subject: [PATCH 2/3] Apply suggestions from code review remove references to "chromium only" --- accessibility/crashtests/aom-in-destroyed-iframe.html | 1 - .../crashtests/computed-accessible-child-of-pseudo-element.html | 1 - accessibility/crashtests/computed-accessible-text-node.html | 1 - accessibility/crashtests/computed-node-checked.html | 1 - 4 files changed, 4 deletions(-) diff --git a/accessibility/crashtests/aom-in-destroyed-iframe.html b/accessibility/crashtests/aom-in-destroyed-iframe.html index 55f074d65c4c60..53ce12ab088f26 100644 --- a/accessibility/crashtests/aom-in-destroyed-iframe.html +++ b/accessibility/crashtests/aom-in-destroyed-iframe.html @@ -5,7 +5,6 @@ // Bypass this abandoned API in all but the engines that implement it. if (typeof getComputedAccessibleNode !== 'undefined') { - // presumed chromium only const frameElem = document.createElement('iframe'); frameElem.srcdoc = 'X
-
'; diff --git a/accessibility/crashtests/computed-accessible-child-of-pseudo-element.html b/accessibility/crashtests/computed-accessible-child-of-pseudo-element.html index f3f3680e44ddd5..91cbf69589f907 100644 --- a/accessibility/crashtests/computed-accessible-child-of-pseudo-element.html +++ b/accessibility/crashtests/computed-accessible-child-of-pseudo-element.html @@ -10,7 +10,6 @@

Heading

// Bypass this abandoned API in all but the engines that implement it. if (typeof getComputedAccessibleNode !== 'undefined') { - // presumed chromium only async function trigger1() { let heading = document.querySelector('h1'); let computed_accessible_node = await self.getComputedAccessibleNode(heading); diff --git a/accessibility/crashtests/computed-accessible-text-node.html b/accessibility/crashtests/computed-accessible-text-node.html index 2028dd065e46c4..4875899340f6cd 100644 --- a/accessibility/crashtests/computed-accessible-text-node.html +++ b/accessibility/crashtests/computed-accessible-text-node.html @@ -5,7 +5,6 @@ // Bypass this abandoned API in all but the engines that implement it. if (typeof getComputedAccessibleNode !== 'undefined') { - // presumed chromium only async function trigger1() { let img = document.getElementById('img1'); let computed_accessible_node = await self.getComputedAccessibleNode(img); diff --git a/accessibility/crashtests/computed-node-checked.html b/accessibility/crashtests/computed-node-checked.html index ae570874adc795..20d461fc5fa1c5 100644 --- a/accessibility/crashtests/computed-node-checked.html +++ b/accessibility/crashtests/computed-node-checked.html @@ -23,7 +23,6 @@ // Bypass this abandoned API in all but the engines that implement it. if (typeof getComputedAccessibleNode !== 'undefined') { - // presumed chromium only const frameElem = document.createElement('iframe'); frameElem.srcdoc = '
'; From 339b5180551946df905ba39b74f56e9108fa354b Mon Sep 17 00:00:00 2001 From: James Craig Date: Tue, 22 Aug 2023 14:16:35 -0700 Subject: [PATCH 3/3] m. "abandoned API" to "abandoned syntax" since similar functionality is still being considered --- accessibility/crashtests/aom-in-destroyed-iframe.html | 2 +- .../crashtests/computed-accessible-child-of-pseudo-element.html | 2 +- accessibility/crashtests/computed-accessible-text-node.html | 2 +- accessibility/crashtests/computed-node-checked.html | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/accessibility/crashtests/aom-in-destroyed-iframe.html b/accessibility/crashtests/aom-in-destroyed-iframe.html index 53ce12ab088f26..c8f0aca12ebbf8 100644 --- a/accessibility/crashtests/aom-in-destroyed-iframe.html +++ b/accessibility/crashtests/aom-in-destroyed-iframe.html @@ -2,7 +2,7 @@