Don't parse color functions with missing parameters. #38203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 26, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4198199
branch
3 times, most recently
from
c83b0a1 to
2d8541b
Compare
From [email protected]: """ This used to be correct per spec, long ago when color() also did custom color spaces and it was reasonable to omit some components and have them auto-filled with zero. Now custom color spaces are in CSS Color 5, and clearly distinguished with a dashed-ident; while predefined color spaces are in CSS Color 4 and are wither an RGB space or an XYZ space. Both take 3 components, as the grammar makes clear. There was some leftover prose about variable number of components, not up to date with the grammar change, which I just corrected. """ Bug: 1410200 Change-Id: I6e1e7d49b91d91a1c61be95a837555f861a5478c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4198199 Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Aaron Krajeski <[email protected]> Cr-Commit-Position: refs/heads/main@{#1098869}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4198199
branch
from
2d8541b to
92561ed
Compare
foolip
added a commit
to foolip/wpt
that referenced
this pull request
Feb 7, 2023
This is causing a harness error due to the same subtest name, which was introduced by two PRs landing on the same day: web-platform-tests#38203 web-platform-tests#38258 Also remove the 3rd argument to test_invalid_value() since it only takes 2 arguments.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 20, 2023
…ue test, a=testonly Automatic update from web-platform-tests Remove duplicate color(srgb) invalid value test This is causing a harness error due to the same subtest name, which was introduced by two PRs landing on the same day: web-platform-tests/wpt#38203 web-platform-tests/wpt#38258 Also remove the 3rd argument to test_invalid_value() since it only takes 2 arguments. -- wpt-commits: 7b06f9e24c3483de76e89d55dc935d4cc4e37622 wpt-pr: 38387
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Feb 23, 2023
…ue test, a=testonly Automatic update from web-platform-tests Remove duplicate color(srgb) invalid value test This is causing a harness error due to the same subtest name, which was introduced by two PRs landing on the same day: web-platform-tests/wpt#38203 web-platform-tests/wpt#38258 Also remove the 3rd argument to test_invalid_value() since it only takes 2 arguments. -- wpt-commits: 7b06f9e24c3483de76e89d55dc935d4cc4e37622 wpt-pr: 38387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From [email protected]:
"""
This used to be correct per spec, long ago when color() also did
custom color spaces and it was reasonable to omit some components and have them auto-filled with zero.
Now custom color spaces are in CSS Color 5, and clearly distinguished
with a dashed-ident; while predefined color spaces are in CSS Color 4
and are wither an RGB space or an XYZ space. Both take 3 components, as
the grammar makes clear.
There was some leftover prose about variable number of components, not up to date with the grammar change, which I just corrected.
"""
Bug: 1410200
Change-Id: I6e1e7d49b91d91a1c61be95a837555f861a5478c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4198199
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Aaron Krajeski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1098869}