Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream animation-ready-promise.html from Blink #3330

Merged
merged 16 commits into from
Apr 11, 2017
Merged

Upstream animation-ready-promise.html from Blink #3330

merged 16 commits into from
Apr 11, 2017

Conversation

suzyh
Copy link
Contributor

@suzyh suzyh commented Jul 26, 2016 •
edited by gsnedders
Loading

@wpt-pr-bot
Copy link
Collaborator

Reviewers for this pull request are: @birtles.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/6727

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@birtles
Copy link
Contributor

birtles commented Sep 2, 2016

The format of these tests looks great. However, I think this is testing from the wrong angle. I think it's better if we approach this by writing tests for each procedure in the timing model, and, for each one that is supposed to touch the ready promise, test it there. I think that's the direction we want to go moving forwards and it's the easiest way to make sure we're giving the spec full coverage without adding redundant tests. What do you think?

@birtles birtles force-pushed the suzyh-upstream-ready-promise branch from 34613d3 to 38e69e7 Compare April 5, 2017 07:16
@ghost
Copy link

ghost commented Apr 5, 2017 •
edited by ghost
Loading

These tests are now available on w3c-test.org

@ghost
Copy link

ghost commented Apr 5, 2017 •
edited by ghost
Loading

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 10a8a3a6b43c54ef4a836678ff35a26b71c37765
Using browser at version BuildID 20170409194145; SourceStamp 45692c884fdd5136a64fb2f8a61a0c8183b69331
Starting 10 test iterations
All results were stable

All results

6 tests ran
/web-animations/interfaces/Animation/idlharness.html
Subtest Results Messages
OK
Animation interface automated IDL tests PASS
Animation interface: existence and properties of interface object PASS
Animation interface object length PASS
Animation interface object name PASS
Animation interface: existence and properties of interface prototype object PASS
Animation interface: existence and properties of interface prototype object's "constructor" property PASS
Animation interface: attribute id PASS
Animation interface: attribute effect PASS
Animation interface: attribute timeline PASS
Animation interface: attribute startTime PASS
Animation interface: attribute currentTime PASS
Animation interface: attribute playbackRate PASS
Animation interface: attribute playState PASS
Animation interface: attribute ready PASS
Animation interface: attribute finished PASS
Animation interface: attribute onfinish PASS
Animation interface: attribute oncancel PASS
Animation interface: operation cancel() PASS
Animation interface: operation finish() PASS
Animation interface: operation play() PASS
Animation interface: operation pause() PASS
Animation interface: operation reverse() PASS
Animation must be primary interface of new Animation() PASS
Stringification of new Animation() PASS
Animation interface: new Animation() must inherit property "id" with the proper type (0) PASS
Animation interface: new Animation() must inherit property "effect" with the proper type (1) PASS
Animation interface: new Animation() must inherit property "timeline" with the proper type (2) PASS
Animation interface: new Animation() must inherit property "startTime" with the proper type (3) PASS
Animation interface: new Animation() must inherit property "currentTime" with the proper type (4) PASS
Animation interface: new Animation() must inherit property "playbackRate" with the proper type (5) PASS
Animation interface: new Animation() must inherit property "playState" with the proper type (6) PASS
Animation interface: new Animation() must inherit property "ready" with the proper type (7) PASS
Animation interface: new Animation() must inherit property "finished" with the proper type (8) PASS
Animation interface: new Animation() must inherit property "onfinish" with the proper type (9) PASS
Animation interface: new Animation() must inherit property "oncancel" with the proper type (10) PASS
Animation interface: new Animation() must inherit property "cancel" with the proper type (11) PASS
Animation interface: new Animation() must inherit property "finish" with the proper type (12) PASS
Animation interface: new Animation() must inherit property "play" with the proper type (13) PASS
Animation interface: new Animation() must inherit property "pause" with the proper type (14) PASS
Animation interface: new Animation() must inherit property "reverse" with the proper type (15) PASS
/web-animations/interfaces/Animation/ready.html
Subtest Results Messages
OK
A new ready promise is created when play()/pause() is called PASS
Redundant calls to play() do not generate new ready promise objects PASS
The ready promise is fulfilled with its Animation PASS
/web-animations/timing-model/animations/canceling-an-animation.html
Subtest Results Messages
OK
A play-pending ready promise should be rejected when the animation is canceled PASS
A pause-pending ready promise should be rejected when the animation is canceled PASS
When an animation is canceled, it should create a resolved Promise PASS
The ready promise should be replaced when the animation is canceled FAIL assert_not_equals: got disallowed value object "[object Promise]"
/web-animations/timing-model/animations/finishing-an-animation.html
Subtest Results Messages
OK
A pending ready promise should be resolved and not replaced when the animation is finished PASS
/web-animations/timing-model/animations/pausing-an-animation.html
Subtest Results Messages
OK
A pending ready promise should be resolved and not replaced when the animation is paused PASS
/web-animations/timing-model/animations/playing-an-animation.html
Subtest Results Messages
OK
Playing a running animation leaves the current time unchanged PASS
Playing a finished animation seeks back to the start PASS
Playing a finished and reversed animation seeks to end PASS
The ready promise should be replaced if the animation is not already pending PASS
A pending ready promise should be resolved and not replaced when the animation enters the running state PASS

@ghost
Copy link

ghost commented Apr 5, 2017 •
edited by ghost
Loading

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 10a8a3a6b43c54ef4a836678ff35a26b71c37765
Using browser at version 59.0.3063.4 dev
Starting 10 test iterations
All results were stable

All results

6 tests ran
/web-animations/interfaces/Animation/idlharness.html
Subtest Results Messages
OK
Animation interface automated IDL tests PASS
Animation interface: existence and properties of interface object FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface object length FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface object name FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: existence and properties of interface prototype object FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: existence and properties of interface prototype object's "constructor" property FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: attribute id FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: attribute effect FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: attribute timeline FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: attribute startTime FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: attribute currentTime FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: attribute playbackRate FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: attribute playState FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: attribute ready FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: attribute finished FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: attribute onfinish FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: attribute oncancel FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: operation cancel() FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: operation finish() FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: operation play() FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: operation pause() FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation interface: operation reverse() FAIL assert_own_property: self does not have own property "Animation" expected property "Animation" missing
Animation must be primary interface of new Animation() FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Stringification of new Animation() FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "id" with the proper type (0) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "effect" with the proper type (1) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "timeline" with the proper type (2) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "startTime" with the proper type (3) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "currentTime" with the proper type (4) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "playbackRate" with the proper type (5) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "playState" with the proper type (6) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "ready" with the proper type (7) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "finished" with the proper type (8) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "onfinish" with the proper type (9) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "oncancel" with the proper type (10) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "cancel" with the proper type (11) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "finish" with the proper type (12) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "play" with the proper type (13) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "pause" with the proper type (14) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
Animation interface: new Animation() must inherit property "reverse" with the proper type (15) FAIL assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Animation is not defined"
/web-animations/interfaces/Animation/ready.html
Subtest Results Messages
OK
A new ready promise is created when play()/pause() is called FAIL Cannot read property 'then' of undefined
Redundant calls to play() do not generate new ready promise objects FAIL Cannot read property 'then' of undefined
The ready promise is fulfilled with its Animation FAIL Cannot read property 'then' of undefined
/web-animations/timing-model/animations/canceling-an-animation.html
Subtest Results Messages
OK
A play-pending ready promise should be rejected when the animation is canceled FAIL Cannot read property 'then' of undefined
A pause-pending ready promise should be rejected when the animation is canceled FAIL Cannot read property 'then' of undefined
When an animation is canceled, it should create a resolved Promise FAIL Cannot read property 'then' of undefined
The ready promise should be replaced when the animation is canceled FAIL assert_not_equals: got disallowed value undefined
/web-animations/timing-model/animations/finishing-an-animation.html
Subtest Results Messages
OK
A pending ready promise should be resolved and not replaced when the animation is finished FAIL Cannot read property 'then' of undefined
/web-animations/timing-model/animations/pausing-an-animation.html
Subtest Results Messages
OK
A pending ready promise should be resolved and not replaced when the animation is paused FAIL Cannot read property 'then' of undefined
/web-animations/timing-model/animations/playing-an-animation.html
Subtest Results Messages
OK
Playing a running animation leaves the current time unchanged PASS
Playing a finished animation seeks back to the start PASS
Playing a finished and reversed animation seeks to end PASS
The ready promise should be replaced if the animation is not already pending FAIL assert_not_equals: got disallowed value undefined
A pending ready promise should be resolved and not replaced when the animation enters the running state FAIL Cannot read property 'then' of undefined

@foolip foolip mentioned this pull request Apr 6, 2017
Closed
@birtles birtles merged commit f8c0ab6 into web-platform-tests:master Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@birtles birtles

Labels
web-animations wg-css wg-svg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suzyh @wpt-pr-bot @hoppipolla-critic-bot @birtles