Reland "Find manifest for download by tags instead of commits" #14209
Conversation
|
Putting up this PR so that I don't forget it later. Should wait until it's clear if the revert fixed the problem or not before relanding. |
| @@ -33,46 +33,53 @@ def should_download(manifest_path, rebuild_time=timedelta(days=5)): | |||
| return False | |||
|
|
|||
|
|
|||
| def git_commits(repo_root): | |||
| def merge_pr_tags(repo_root, max_count=50): | |||
There was a problem hiding this comment.
This can't be relanded as-is even if it wasn't the cause of the failures, because tags aren't fetched in the Taskcluster setup: #14207 (comment)
|
@jgraham @lukebjerring the original PR is a case where a full Taskcluster run that mimics as closely as possible the master-triggered runs would have been very valuable. What are the steps required to make that happen? Seems like something we should capture in WPT 2019 priorities. |
|
Basically, needs to run on a fork with Taskcluster enabled (always instead of current master-only). I'll do that for you. |
|
If we wanted a mechanism to request a full run from a PR in this repo, what are the constraints? I guess adding/removing labels wouldn't work, only updating branches would? If Taskcluster had deep integration with the new checks API, then an action (button) that says "request full run" would be neat, but I doubt it'd be high on the Taskcluster team's priorities. |
|
I'm not familiar with TaskCluster's capabilities, but if we can branch based on a PR's labels, that would be nice and clean - we add "if the PR is labelled |
|
You can see the results of the full runs here: |
|
Thanks! Clearly relanding this would break things again, so definitely I shouldn't do that yet :) |
|
We now fetch tags in taskcluster since #14315 landed, so I think this can land. |
|
Yay! @jgraham, feel free to approve and merge, at a time when you can keep on eye on master to see if it broke everything again. |
Reverted in #14208
as possible cause of #14207.
This reverts commit 5438f72.