Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ignore includers of untested mixins (#13611)" #13877

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Conversation

Hexcles
Copy link
Member

@Hexcles Hexcles commented Nov 2, 2018

This reverts commit e9e06cd.

This broke some IDL tests. Some intended subtests were dropped because of this change. Example: https://chromium-review.googlesource.com/c/chromium/src/+/1307069/4/third_party/WebKit/LayoutTests/external/wpt/css/css-transitions/idlharness-expected.txt (all the FAIL lines disappeared, which caused the removal of the whole expectation file.)

@Hexcles Hexcles requested a review from lukebjerring November 2, 2018 17:27
@Hexcles
Copy link
Member Author

Hexcles commented Nov 2, 2018

@foolip looks like an Azure flake:

https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=136&view=logs

System.InvalidOperationException: Git fetch failed with exit code: 128
   at Agent.Plugins.Repository.GitSourceProvider.GetSourceAsync(AgentTaskPluginExecutionContext executionContext, RepositoryResource repository, CancellationToken cancellationToken)
   at Agent.Plugins.Repository.CheckoutTask.RunAsync(AgentTaskPluginExecutionContext executionContext, CancellationToken token)
   at Agent.PluginHost.Program.Main(String[] args)

I'm admin-merging this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants