The issue of test case skip-waiting-installed.https.html

[xzhan96]

There is a discussion about the behavior of skipWaiting() in ServiceWorker issues 1015 , and the final decision should be in pull 1019:

promise resolves right away after setting the skip waiting flag

If I understand right, then there maybe a issue in the test skip-waiting-installed.https.html.

    var saw_message = new Promise(function(resolve) {
        onmessage = function(e) {
            resolve(e.data);
          };
        })
      .then(function(message) {
          assert_equals(
            message, 'PASS',
            'skipWaiting promise should be resolved with undefined');

          assert_equals(registration.active.scriptURL, normalizeURL(url2),
                        'skipWaiting should make worker become active');
        });

When the saw_message was called, registration.active.scriptURL should be still url1 instead of url2, because skipWaiting() will be executed just after new service worker is "installed" and before it become "activating"/"activated".

[xzhan96]

@wanderview please check if it is an issue.

[wanderview]

I'm on PTO this week. @asutherland, what do you think?

[xzhan96]

@asutherland could you confirm if it's an issue?

[asutherland]

Apologies for the delay; I've improved my email filters for mentions.

Yes, the test was wrong. Your fix on #6564 looks right to me and is consistent with the gecko-local patch I had on bug 1318142 which was the original source of the issue I raised.

[xzhan96]

@asutherland Thanks for your explanation.
So I will drop my #6564 and wait your patch merged. Another question is that if you patch will sync to Chromium/third_party/WebKit/LayoutTests/external/wpt automatically ? or need to cherry-pick?

[makotoshimazu]

@xzhan96
There is daily (weekly?) sync for layout tests in external/wpt. We don't need to cherry-pick manually.

[xzhan96]

Ok, so let's wait for asutherland's patch. Can we know when it will be merged?

[asutherland]

@xzhan96 I think it makes sense to keep and merge your #6564 fix now. My efforts on that bug have not yet landed in Gecko and it will be at least a week (possibly longer) before they do.

[xzhan96]

Ok, thanks a lot. :-)