Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the major version of pip to 20 in Python 2 #24636

Closed
Hexcles opened this issue Jul 16, 2020 · 6 comments
Closed

Pin the major version of pip to 20 in Python 2 #24636

Hexcles opened this issue Jul 16, 2020 · 6 comments

Comments

@Hexcles
Copy link
Member

Hexcles commented Jul 16, 2020

I noticed that pip would drop support for Python 2 starting from v21: pypa/pip#6148

We've been seeing the deprecation warnings when running wpt run without --py3:

DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support

The timeline seems to be January 2021. And we need to pin the version of pip everywhere we run Python 2 (including the wpt frontend and various tox tests).

@stephenmcgruer
Copy link
Contributor

At this point we're hoping to be Py3-first by Jan 2021, but we will likely have a few Py2 bots (infra/ tests, some unittests) to help with backwards compatibility, which will still have to be pinned.

Leaving this roadmap, because we'll want a reminder before the end of the year to get this done! :)

@foolip
Copy link
Member

foolip commented Dec 1, 2020

Here's the reminder before the year is over! Who should be assigned to this?

@stephenmcgruer stephenmcgruer self-assigned this Dec 1, 2020
@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Jan 19, 2021

cc @jgraham @gsnedders as folks who might want to know - based on pypa/pip#9282 (comment) this will break in the very last week of us being Py2-compatible (pip is aiming to release on Jan 23/24).

I'm very tempted to declare we're moving the py3-only shift forward by a week...

@jgraham
Copy link
Contributor

jgraham commented Jan 20, 2021

I think I'm happy with spending the time to move stuff over to Py 3 where required rather than pinning pip.

@stephenmcgruer
Copy link
Contributor

pip21 was released this weekend. So far I haven't seen any breakages, so we might just get away with this ;)

@jgraham
Copy link
Contributor

jgraham commented Feb 2, 2021

I'm going to say we can close this now.

@jgraham jgraham closed this as completed Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants