Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move browser discovery into wptrunner #12719

Open
gsnedders opened this issue Aug 28, 2018 · 1 comment
Open

Move browser discovery into wptrunner #12719

gsnedders opened this issue Aug 28, 2018 · 1 comment
Labels
infra priority:backlog wpt wptrunner The automated test runner, commonly called through ./wpt run

Comments

@gsnedders
Copy link
Member

gsnedders commented Aug 28, 2018

At the moment, we have a mixture of logic in tools/wpt/browser.py and tools/wptrunner/wptrunner/webdriver_server.py and tools/wptrunner/wptrunner/browser/*.py; we should simplify all this.

We have:

  • ways to find a binary in multiple places (I'm not sure what wptrunner itself even does in some cases, and I can't figure out how to run it in isolation)
  • browser_version passed in as a kwarg to wptrunner.start from wpt.run, but doesn't get passed in in any other way (everything else that ends up in kwargs comes from the argument parser)

On the face of it, what we want in wpt is just the installation management side of things.

@gsnedders gsnedders added infra wpt wptrunner The automated test runner, commonly called through ./wpt run labels Aug 28, 2018
@jgraham
Copy link
Contributor

jgraham commented Aug 31, 2018

I don't think wptrunner is doing anything complex; it just takes the binary you pass it through command line options and uses that. The only change is can make is wrapping it in a debugger if you are trying to run under gdb or similar. Is that not the case?

I changed the browser_version thing as part of #12679

That said I agree with the conceptual separation that wpt run should deal with setting up the environment, and wptrunner should use the provided environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra priority:backlog wpt wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

No branches or pull requests

3 participants