From 8a34c3b3fd8001f94476c185457c60e4c22ec955 Mon Sep 17 00:00:00 2001 From: Alison Maher Date: Mon, 10 Feb 2020 19:28:52 -0800 Subject: [PATCH] [LayoutNG] Update legends from getting painted atomically Legends were getting painted atomically via NGFieldsetPainter::PaintLegend(). This is not according to the spec: https://html.spec.whatwg.org/#the-fieldset-and-legend-elements. Removing the atomic painting of legends also fixes crashing issues in which floating children of legends were getting painted twice. This change adds several test failures to the TestExpectations file. These failures, however, are temporary and will be fixed in a soon-to-follow CL: https://chromium-review.googlesource.com/c/chromium/src/+/2042146 Bug: 875235 Change-Id: I2b9dbc438ba241bcf72eca316ec65aa2f1edc635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045194 Commit-Queue: Alison Maher Reviewed-by: Morten Stenshorne Cr-Commit-Position: refs/heads/master@{#740147} --- .../legend-painting-order-ref.html | 5 +++++ .../legend-painting-order.html | 13 +++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-painting-order-ref.html create mode 100644 html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-painting-order.html diff --git a/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-painting-order-ref.html b/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-painting-order-ref.html new file mode 100644 index 00000000000000..94f4991f2272da --- /dev/null +++ b/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-painting-order-ref.html @@ -0,0 +1,5 @@ + +Reference for fieldset painting order + +

There should be a green square below, and no red.

+
diff --git a/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-painting-order.html b/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-painting-order.html new file mode 100644 index 00000000000000..ac0bd430374509 --- /dev/null +++ b/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-painting-order.html @@ -0,0 +1,13 @@ + +Legend painting order + + +

There should be a green square below, and no red.

+
+
+
+
+ +
+ +