From 15ec309c915ee9dfe09e14132382e6d09ed9d28c Mon Sep 17 00:00:00 2001 From: Christian Biesinger Date: Tue, 5 Mar 2019 15:22:05 -0800 Subject: [PATCH] [css-flexbox] Don't always add the child as percentage-sized child ComputePercentageLogicalHeight has the side-effect of calling AddPercentHeightDescendant on the containing block; that is not great when we just want to check if a size is definite, from MainSizeIsDefiniteForPercentageResolution. Add a parameter to make it optional. Also change CrossAxisSizeIsDefinite over to this function. Here, we do not have to worry about AddPercentHeightDescendant because we will later resolve that size through normal mechanisms anyway. Bug: 933931 Change-Id: Id44d15eb546c15bbdece99282550419eb0f8654e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492294 Commit-Queue: Christian Biesinger Reviewed-by: Emil A Eklund Cr-Commit-Position: refs/heads/master@{#637885} --- .../flex-minimum-height-flex-items-013.html | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 css/css-flexbox/flex-minimum-height-flex-items-013.html diff --git a/css/css-flexbox/flex-minimum-height-flex-items-013.html b/css/css-flexbox/flex-minimum-height-flex-items-013.html new file mode 100644 index 000000000000000..9989b6463780fad --- /dev/null +++ b/css/css-flexbox/flex-minimum-height-flex-items-013.html @@ -0,0 +1,49 @@ + + +CSS Flexbox: min-height: auto with nested flexboxes + + + + + + + + +

Test passes if there is a filled green square and no red.

+ +
+
+
+
+
+
+
+ + + +