Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks compare stable v. experimental baseline #901

Closed
gsnedders opened this issue Dec 12, 2018 · 4 comments
Closed

Checks compare stable v. experimental baseline #901

gsnedders opened this issue Dec 12, 2018 · 4 comments

Comments

@gsnedders
Copy link
Member

gsnedders commented Dec 12, 2018

e.g. https://github.com/web-platform-tests/wpt/runs/40189217:

this shows:

Run Spec
master chrome-72.0.3626.14 dev-linux-18.04@9bf305b4ed
48d5d50 chrome-71.0.3578.80-linux-18.04@48d5d5033d

The comparison of Chrome 72 v. Chrome 71 seems bogus.

And the chrome[experimental] run (https://github.com/web-platform-tests/wpt/runs/40181992) shows the equally bogus:

Run Spec
master chrome-71.0.3578.80-linux-18.04@48d5d5033d
48d5d50 chrome-72.0.3626.14 dev-linux-18.04@48d5d5033d
@lukebjerring
Copy link
Contributor

Fairly sure this will be fixed by #889 which plumbs the experimental label through to the GetDiffURL command.

@Hexcles
Copy link
Member

Hexcles commented Dec 12, 2018

@lukebjerring no, that's a separate issue. IIUC, GetDiffURL is only responsible for generating the link, not for finding the runs. I think the problem here is that we need to pass the labels from the receiver to ScheduleResultsProcessing.

@lukebjerring
Copy link
Contributor

OK, this was introduced in #881, and I've amended #889 to indeed fix the problem.

@Hexcles
Copy link
Member

Hexcles commented Dec 13, 2018

Should be fixed now.

@Hexcles Hexcles closed this as completed Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants