-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the same color scheme in results and interop view #423
Comments
Currently, we use paper colors in interop, with the alpha channel changing: But we use something different in wpt-results: And, something different again in the individual files... |
Another consideration is picking colors that work with black text. The darkest red we now use might be a tad too dark really. |
Note that once #674 lands, badge colors will need to be consistent with these choices too. |
In light of #674, having a discontinuity between yellow and green between 99% and 100% doesn't seem so great. In the form of a badge, it might create the incentive to defend a 100% status in a way that isn't helpful for interoperability. (This of course might happen on wpt.fyi itself as well, but seems less likely.) https://software.hixie.ch/utilities/js/live-dom-viewer/saved/6331 is a computed red-to-green scale, which I don't find that good, in particular the yellow range is too narrow: https://software.hixie.ch/utilities/js/live-dom-viewer/saved/6332 uses a fixed palette (from paper-styles) and reserves the reddest and greenest ends for 0 / N and N / N. With that tweak and few enough colors, it's still easy to distinguish 99% from 100%: https://software.hixie.ch/utilities/js/live-dom-viewer/saved/6333 cuts out the shades between yellow and green to match my original proposal, but I don't think it's really an improvement: So, 6332 would be my updated proposal. |
For the interop view, I think using the same colors but scaling the lightness might still work. |
https://staging.wpt.fyi/results/css/css-animations looks like this:
https://staging.wpt.fyi/interop/css/css-animations looks like this:
The interop view uses a red->orange->yellow->green color scheme, where the colors are faded to white based on the proportion of the total number of tests that fall into the column.
The results view uses a red->pink->green color scheme, where total failure is red, 99% passing is pink, and 100% is green.
I'd like to suggest a more consistent color scheme for both:
The text was updated successfully, but these errors were encountered: