Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions Safari runs not labelled with master #4063

Closed
gsnedders opened this issue Oct 17, 2024 · 0 comments · Fixed by #4067
Closed

GitHub Actions Safari runs not labelled with master #4063

gsnedders opened this issue Oct 17, 2024 · 0 comments · Fixed by #4067

Comments

@gsnedders
Copy link
Member

This excludes them from the default view, see e.g. https://staging.wpt.fyi/results/?run_id=6174988006588416

The problem lies in:

if (*workflowRun.Event == "push" &&
*workflowRun.HeadRepository.Owner.Login == owner &&
*workflowRun.HeadRepository.Name == repo) &&
(*workflowRun.HeadBranch == "master" ||
epochBranchesRegex.MatchString(*workflowRun.HeadBranch)) {
labels.Add(shared.MasterLabel)
}

We're both checking that the event is push (it isn't, it's workflow_run after web-platform-tests/wpt@2419936), and the head branch the workflow run is triggered against is actually mostly irrelevant (see web-platform-tests/wpt#48659; we need to manually checkout the right ref to actually run what we want to).

Without this in the workflow_run payload, we don't actually have an easy way to pass what we're actually running against to wpt.fyi. We could maybe add this to what we upload to notify wpt.fyi, but that clearly has security considerations (though maybe if we're running against master on the right repo we can trust what we upload?).

An easy-but-bad temporary fix is to just label every workflow_run with master, which is currently true because we should only ever be running things that are on master in that case. This might be worthwhile to unblock this?

(See also #4020, given this is now the thing stopping the runs from showing up by default.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant