Skip to content
This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

Extend identification of result-sets to support multiple versions #512

Closed
mariestaver opened this issue Mar 11, 2018 · 2 comments
Closed
Assignees
Labels

Comments

@mariestaver
Copy link
Collaborator

No description provided.

@jugglinmike
Copy link
Collaborator

The issue here is that although we report the browser name and version with each result set, the Golang code differentiates received results by browser name only. This represents a race condition if we were to collect and upload results from two versions of the same browser concurrently. In that case, the version displayed on https://wpt.fyi would be determined by scheduling details (i.e. the results for the most recently-completed browser version would be displayed).

Luke, Robert, and I met today to discuss this. We agreed that in the short term, the runner should upload results for experimental browsers with a distinct name (e.g. chrome-experimental and firefox-experimental), ensuring consistency with the website's current behavior.

This will be reflected in my initial solution for gh-521 and gh-388. Luke confirmed his intention to make the necessary modifications to the Golang code, so I'll re-assign this issue to him.

@foolip
Copy link
Member

foolip commented Apr 17, 2018

I think this is the same as web-platform-tests/wpt.fyi#60 so I'm closing in favor of that. Possibly there's also work needed in web-platform-tests/wpt.fyi#55 (@Hexcles) to provide all the metadata needed. Please file more issues if something's missing.

@foolip foolip closed this as completed Apr 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants