-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grid/flex test-suites for 2023 #242
Comments
I'm not sure there's a well defined process here; we (with agreement) accept updates to the 2022 testsuites, but generally adding scope for a subsequent year should be in the context of a new focus area. If there are areas where bugs are showing up as site breakage or compat problems, the tests might be suitable for the web compatibility focus area. |
Self-assigning to label the tests with a temporary label to show what the impact on the scores would be. |
I'm going through and labeling with |
I also won't label anything names -print or -crash. |
You likely want to keep those tentative tests, they just need spec text surrounding them.. |
@bfgeek do you know which spec issue those tests depend on? (Nothing is linked from the tests.) |
Thank you for proposing updated grid/flex tests for inclusion in Interop 2023. We are pleased to let you know that this proposal was accepted as part of the existing Flexbox and Grid focus areas. You can follow the progress of these Focus Areas on the Interop 2023 dashboard. For an overview of our process, see the proposal selection summary. Thank you for contributing to Interop 2023! Posted on behalf of the Interop team. |
Test List
https://wpt.fyi/results/css/css-flexbox?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=%21label%3Ainterop-2021-flexbox
Include all of the flex tests above except for:
Tests relating to the "new" intrinsic sizing algorithm.
flex-container-max-content-001.html
flex-container-min-content-001.html
intrinsic-size/*
Tests relating to "visibility: collapse" (additional feature).
flexbox_visibility-collapse-line-wrapping.html
flexbox_visibility-collapse.html
flexbox-collapsed-item-baseline-001.html
flexbox-collapsed-item-horiz-001.html
flexbox-collapsed-item-horiz-002.html
flexbox-collapsed-item-horiz-003.html
https://wpt.fyi/results/css/css-grid?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=%21label%3Ainterop-2021-grid
Include all of the grid tests above except for:
Masonry feature:
masonry/*
The align-content:baseline feature (additional feature).
alignment/grid-item-content-baseline-001.html
alignment/grid-item-content-baseline-002.html
alignment/grid-item-content-baseline-003.html
alignment/grid-item-content-baseline-004.html
alignment/grid-item-mixed-baseline-001.html
alignment/grid-item-mixed-baseline-002.html
alignment/grid-item-mixed-baseline-003.html
alignment/grid-item-mixed-baseline-004.html
alignment/grid-baseline-align-001.html
alignment/grid-baseline-justify-001.html
Non web-compatible:
grid-definition/grid-inline-template-columns-rows-resolved-values-001.tentative.html
grid-definition/grid-template-columns-rows-resolved-values-001.tentative.html
Rationale
Over the last 1-2 years we've slowly added test-cases to the suites from bug reports we've received[1], or spec clarifications/behaviour changes[2].
Additionally this is updated for the "last baseline" alignment feature which all engines have basic support for now.
[1] https://bugs.chromium.org/p/chromium/issues/detail?id=1126609 or https://bugs.chromium.org/p/chromium/issues/detail?id=768999
[2] web-platform-tests/wpt@fc109c5
Ian
The text was updated successfully, but these errors were encountered: