-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css conic-gradient
#174
Comments
Fuzzy matching could be used to make these tests pass, assuming some small deviations are expected. |
I don't think we want to. At the end of the day these later become blockers for authors for releasing products over the web platform. These are probably best kept as failing, though not sure whether this also calls for an interop candidate 🤔 |
The question is how big the differences are, are they big enough to be observable? For normalization-conic.html the maximum pixel difference is just 1, and that's a case we often use fuzzy matching for. Making the appropriate tests fuzzy also makes it clearer if there are any big differences left. @jsnkuhn @ydaniv do you know of issues with conic gradients that aren't related to these failing tests? As a quick check I looked for "conic-gradient safari" on Stack Overflow, but didn't find anything. |
Don't know of any.
The "tiled" test seems quite off on the edges, perhaps AA-related issues. The rest are off by 1 on each channel, perhaps less critical. |
nope, i don't know of any other conic-gradient issues. Did find a webkit bug open for a bunch of failing |
In the State of CSS 2022 question about browser incompatibilities, there was only a single mention of The response was just "conic-gradients" with no further detail. |
Thank you for proposing CSS We wanted to let you know that this proposal was not selected to be part of Interop this year. We found that the test failures in WPT are due to very minor differences in rendering, and believe this feature is already largely interoperable. For an overview of our process, see the proposal selection summary. Thank you again for contributing to Interop 2023! Posted on behalf of the Interop team. |
Description
From spec
Rationale
As I've been looking through the tests for other focus areas I randomly noticed that Safari seems to be failing most of the
conic-gradient
tests. I'm on windows so I checked caniuse (https://caniuse.com/?search=conic) a long time ago and assumed that conic-gradients were safe to use in all browsers. If support is really this bad in Safari I think there are a few projects that I'll have to go back and drop in fall back images for.Can someone on Safari confirm that the conic-gradient tests are broken?
Specification
https://drafts.csswg.org/css-images-4/#conic-gradients
Tests
https://wpt.fyi/results/css/css-images?label=master&label=experimental&aligned&view=subtest&q=conic
The text was updated successfully, but these errors were encountered: