Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip on reviewing markdown #120

Closed
foolip opened this issue Aug 25, 2022 · 1 comment
Closed

Tip on reviewing markdown #120

foolip opened this issue Aug 25, 2022 · 1 comment
Labels
meta Process and/or repo issues

Comments

@foolip
Copy link
Member

foolip commented Aug 25, 2022

It's come up that reviewing diffs is inconvenient, for example in #102, so these are the steps to show the rendered markdown:

First, go to the "Files changed" tab, the diff view, for example https://github.com/web-platform-tests/interop/pull/115/files

Then find the markdown file to review and do one of:

  • Click the 📄 icon with label "Display the rich diff"
  • Click the "..." icon and then "View file"

To comment on a specific bit of the document, you still have to find it in the diff. But just a comment on the PR would be fine as well.

@web-platform-tests/interop FYI.

@foolip foolip closed this as completed Aug 25, 2022
@foolip
Copy link
Member Author

foolip commented Aug 25, 2022

Screenshot showing the two ways:

image

@gsnedders gsnedders added the meta Process and/or repo issues label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Process and/or repo issues
Projects
None yet
Development

No branches or pull requests

2 participants