fix: not generate ssr route runtime module when client build #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
previously approved these changes
May 17, 2024
Timeless0911
force-pushed
the
fix/generate-runtime-route
branch
3 times, most recently
from
d459c42
to
ecc54f5
Compare
Timeless0911
force-pushed
the
fix/generate-runtime-route
branch
from
ecc54f5
to
378f582
Compare
Timeless0911
changed the title
chenjiahan
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Generate route virtual modules based on
isSSRin different build modes.Not generate ssr route runtime module when client build.
This avoids the SSR routing virtual module generated by client build from affecting the module number calculation of lazy compilation.
When ssr build, the client route runtime module still generated since some route match logic function need this structure.
Related Issue
web-infra-dev/rspack#5915
Checklist