-
-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trusted type with devtool eval #7866
Conversation
7b80eb8
to
b7cc89f
Compare
✅ Deploy Preview for rspack canceled.
|
Test Compatibility Diff
Unpassed tests6 🔴 Stats chunkGroups: TODO |
@LingyuCoder @SyMind I just upgraded from 1.04 to 1.0.5 and started running into the below error when initializing the worker script. it is a simple worker init code as below which was working fine in the previous version and I suspect this change could have broken it. Can you please advise? Thanks. |
Can you print the |
Seems there is a bug in CreateScriptUrlRuntimeModule here. I will try to fix it. This is wired. This runtime module should only be added when |
Thank you @LingyuCoder for the super fast turn around fix. I do have output.trustedTypes set . I disabled it , still ran into the same error. Is there a temporary hack/ workaround you can suggest to get it working ? i.e to avoid hitting that problematic code. |
You can try using Not sure whether there are other bugs. Maybe the compiled code and the parameters of |
@LingyuCoder I just tried the 1.0.11 v with the above fix , but I am still running into that same issue. I filed the following bug to track the same. |
Summary
eval(module)
should beeval(__webpack_require__.ts(module))
to make sure that the module script is a trusted scriptcompilation.output.trustedTypes
without any module level logicChecklist