-
-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Path
pitfall for loader type
#7666
Conversation
✅ Deploy Preview for rspack canceled.
|
Test Compatibility Diff
Unpassed tests4 🔴 Stats chunkGroups: TODO |
Summary
There's a pitfall for
Path::ends_with
. It only matches by components. We need to either convert to&str
or usePath::extension
.Use
Path::as_str
to match extensions instead ofPath::extension
for performance. The second one analyzescomponents
first.Checklist