-
-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: enable "fat" LTO for production release #7088
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team
The issue/pr is created by the member of Rspack.
release: performance
release: performance related release(mr only)
labels
Jul 9, 2024
✅ Deploy Preview for rspack canceled.
|
!bench |
📝 Benchmark detail: Open
|
chenjiahan
changed the title
perf: enable "fat" LTO for release
perf: enable "fat" LTO for production release
Jul 9, 2024
JSerFeng
approved these changes
Jul 9, 2024
Cool, I thought we were already use fat in production release long ago |
h-a-n-a
approved these changes
Jul 9, 2024
Haha, I guess the reason for using "thin" before was mainly due to CI time. And it is worth to enable "fat" if it only affects the prod release |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: performance
release: performance related release(mr only)
team
The issue/pr is created by the member of Rspack.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pros
Cons
see:
Checklist