fix: panic when get max target in find target #7082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team
✅ Deploy Preview for rspack canceled.
|
chenjiahan
reviewed
Jul 9, 2024
h-a-n-a
reviewed
Jul 9, 2024
h-a-n-a
approved these changes
Jul 9, 2024
JSerFeng
approved these changes
Jul 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #7057
fix #7062
fix #7077
fix #7078
In webpack, module graph is always mutable and will insert the max target of export info while getting it, even during the code gen.
But in rspack, module graph should be immutable during the code gen. So can only get max target when it has been set. If it is not exists, export info should generate it but not set it into export info.
Checklist