Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: use swc_plugin_prefresh instead of builtin swc plugin #7069

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

LingyuCoder
Copy link
Collaborator

Summary

  • Upgrade swc_core to 0.96.9
  • Remove swc_plugin, use @swc/plugin-prefresh instead

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder LingyuCoder added the release: breaking change release: breaking change related release(mr only) label Jul 8, 2024
@LingyuCoder LingyuCoder requested a review from h-a-n-a July 8, 2024 06:19
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jul 8, 2024
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 9d284ce
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/668b8632cff8af0008c998ce

@LingyuCoder LingyuCoder enabled auto-merge (squash) July 8, 2024 06:27
@LingyuCoder LingyuCoder merged commit 36673f2 into main Jul 8, 2024
29 checks passed
@LingyuCoder LingyuCoder deleted the refactor/swc-prefresh-plugin branch July 8, 2024 06:37
@chenjiahan
Copy link
Member

!bench

@rspack-bot
Copy link

rspack-bot commented Jul 8, 2024

📝 Benchmark detail: Open

Name Base (2024-07-08 d14720d) Current Change
10000_development-mode + exec 2.16 s ± 25 ms 2.16 s ± 20 ms +0.06 %
10000_development-mode_hmr + exec 692 ms ± 2.9 ms 692 ms ± 7.2 ms -0.02 %
10000_production-mode + exec 2.73 s ± 23 ms 2.78 s ± 24 ms +1.63 %
arco-pro_development-mode + exec 1.91 s ± 87 ms 1.89 s ± 74 ms -1.11 %
arco-pro_development-mode_hmr + exec 435 ms ± 3.2 ms 434 ms ± 1.4 ms -0.24 %
arco-pro_production-mode + exec 3.42 s ± 95 ms 3.44 s ± 41 ms +0.53 %
threejs_development-mode_10x + exec 1.58 s ± 19 ms 1.59 s ± 13 ms +0.91 %
threejs_development-mode_10x_hmr + exec 798 ms ± 6.9 ms 822 ms ± 13 ms +3.11 %
threejs_production-mode_10x + exec 5.58 s ± 29 ms 5.62 s ± 33 ms +0.84 %

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: breaking change release: breaking change related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants