feat!: detect conflicting values in DefinePlugin
#7045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-a-n-a
added
the
release: breaking change
github-actions
bot
added
the
release: feature
github-actions
bot
added
the
team
✅ Deploy Preview for rspack canceled.
|
h-a-n-a
commented
Jul 4, 2024
ahabhgk
reviewed
Jul 4, 2024
ahabhgk
force-pushed
the
feat/define-conflict
branch
from
6275ad1
to
41b0855
Compare
ahabhgk
approved these changes
Jul 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Conflict values in
DefinePluginare being detected.If different values were assigned to the same key, latter keys were ignored.
Previously, if keys were the same, rspack will use the new value to override the previous one.
closes #6821
Checklist