Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate Compiler and MultiCompiler API #6448

Merged
merged 1 commit into from
May 14, 2024
Merged

feat: deprecate Compiler and MultiCompiler API #6448

merged 1 commit into from
May 14, 2024

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented May 6, 2024

Summary

Removed API

~ v0.6.x v0.7.0 ~ Description
Compiler.builtinPlugins Compiler.__internal__builtinPlugins Marked as internal
Compiler.compilation Compiler._lastCompilation
Compiler.compilationParams -
Compiler.getAsset(name) -
Compiler.ruleSet -
Compiler.getAsset(name) -
MultiCompiler.context -
MultiCompiler.infrastructureLogger -
MultiCompiler.name -
MultiCompiler.resolverFactory -
MultiCompiler.root -
MultiCompiler.watching -
MultiCompiler.watchMode -
  • APIs prefixed with __internal__ should not be touched in upper-level packages and subject to change.
  • APIs with no alternative provided by v0.7.0 ought to be aligned with webpack.

Newly added API

  • ChunkGroup.chunks: Chunk[]
  • exported type OutputFileSystem

Other breaking changes

  • Compiler.getInfrastructureLogger: getInfrastructureLogger(name: string | Function): Logger -> getInfrastructureLogger(name: string | (() => string)): Logger
  • Compiler.runAsChild: runAsChild(callback: any): void -> runAsChild(callback: (err?: null | Error, entries?: Chunk[], compilation?: Compilation) => any): void
  • Compiler.watchFileSystem: watchFileSystem: WatchFileSystem -> watchFileSystem: WatchFileSystem | null
  • Compiler.outputFileSystem: typeof import("fs") -> OutputFileSystem | null

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label May 6, 2024
Copy link

netlify bot commented May 6, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit b425189
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6643329bb2ce66000831046f

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 6, 2024
@h-a-n-a h-a-n-a force-pushed the deprecate-api branch 7 times, most recently from c3c5ddd to 14e703c Compare May 8, 2024 11:31
@h-a-n-a h-a-n-a marked this pull request as ready for review May 8, 2024 11:51
@h-a-n-a h-a-n-a changed the title feat: deprecate apis in v0.7 feat: deprecate Compiler and MultiCompiler API in v0.7 May 8, 2024
@h-a-n-a h-a-n-a force-pushed the deprecate-api branch 4 times, most recently from e16141b to 449fcf1 Compare May 9, 2024 10:57
@h-a-n-a
Copy link
Collaborator Author

h-a-n-a commented May 10, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented May 10, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
nx ✅ success
rspress ✅ success
rsbuild ❌ failure
compat ✅ success
examples ✅ success

Copy link
Collaborator Author

h-a-n-a commented May 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @h-a-n-a and the rest of your teammates on Graphite Graphite

@h-a-n-a
Copy link
Collaborator Author

h-a-n-a commented May 14, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented May 14, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
nx ✅ success
rspress ✅ success
rsbuild ❌ failure
compat ✅ success
examples ✅ success

@h-a-n-a h-a-n-a changed the title feat: deprecate Compiler and MultiCompiler API in v0.7 feat: deprecate Compiler and MultiCompiler API May 14, 2024
@h-a-n-a h-a-n-a added breaking change release: breaking change release: breaking change related release(mr only) labels May 14, 2024
@9aoy 9aoy mentioned this pull request May 14, 2024
@h-a-n-a h-a-n-a merged commit f4b669a into main May 14, 2024
34 checks passed
@h-a-n-a h-a-n-a deleted the deprecate-api branch May 14, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: breaking change release: breaking change related release(mr only) release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants