Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: finish make and finish modules hook #5990

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

ahabhgk
Copy link
Collaborator

@ahabhgk ahabhgk commented Mar 21, 2024

Summary

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 21, 2024
@ahabhgk ahabhgk marked this pull request as ready for review March 21, 2024 05:48
@ahabhgk ahabhgk requested a review from hardfist as a code owner March 21, 2024 05:48
@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Mar 21, 2024

!bench

@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Mar 21, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Mar 21, 2024

📝 Benchmark detail: Open

Name Base (2024-03-21 6b6429d) Current Change
10000_development-mode + exec 1.92 s ± 30 ms 1.98 s ± 22 ms +3.02 %
10000_development-mode_hmr + exec 743 ms ± 12 ms 743 ms ± 9.6 ms -0.02 %
10000_production-mode + exec 2.97 s ± 39 ms 2.8 s ± 15 ms -5.59 %
arco-pro_development-mode + exec 2.5 s ± 33 ms 2.51 s ± 44 ms +0.35 %
arco-pro_development-mode_hmr + exec 508 ms ± 14 ms 516 ms ± 5.7 ms +1.59 %
arco-pro_development-mode_hmr_intercept-plugin + exec 527 ms ± 4.4 ms 526 ms ± 11 ms -0.21 %
arco-pro_development-mode_intercept-plugin + exec 3.33 s ± 44 ms 3.32 s ± 60 ms -0.29 %
arco-pro_production-mode + exec 4.09 s ± 42 ms 4.11 s ± 50 ms +0.48 %
arco-pro_production-mode_intercept-plugin + exec 4.96 s ± 46 ms 4.95 s ± 44 ms -0.11 %
threejs_development-mode_10x + exec 1.88 s ± 13 ms 1.92 s ± 30 ms +1.86 %
threejs_development-mode_10x_hmr + exec 740 ms ± 6.1 ms 738 ms ± 4.1 ms -0.23 %
threejs_production-mode_10x + exec 5.85 s ± 37 ms 5.9 s ± 63 ms +0.80 %

@rspack-bot
Copy link

rspack-bot commented Mar 21, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
nx ❌ failure
rspress ✅ success
rsbuild ✅ success
compat ✅ success
examples ❌ failure

@ahabhgk
Copy link
Collaborator Author

ahabhgk commented Mar 21, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Mar 21, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
nx ✅ success
rspress ✅ success
rsbuild ✅ success
compat ✅ success
examples ✅ success

@ahabhgk ahabhgk merged commit 923e999 into main Mar 21, 2024
28 checks passed
@ahabhgk ahabhgk deleted the 03-21-refactor_finish_make_and_finish_modules_hook branch March 21, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants