Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: module_graph update module align with webpack #5692

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix: module_graph update module align with webpack #5692

merged 1 commit into from
Feb 20, 2024

Conversation

jerrykingxyz
Copy link
Collaborator

Summary

  • update module align with webpack module_graph.updateModule
  • module_graph.revokeConnection should remove active connection if current connection not active

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Feb 19, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 19, 2024
@jerrykingxyz jerrykingxyz linked an issue Feb 19, 2024 that may be closed by this pull request
Rspress HMR is broken after enabling new tree shaking #5270
Closed
@jerrykingxyz jerrykingxyz force-pushed the jerry/update_module branch 2 times, most recently from 9c70bac to c26a4d4 Compare February 20, 2024 08:38
@jerrykingxyz jerrykingxyz linked an issue Feb 20, 2024 that may be closed by this pull request
[Bug]: using concatenateModules with rspack serve cause runtime panic "should have build info" #5594
Closed
@jerrykingxyz jerrykingxyz enabled auto-merge (squash) February 20, 2024 09:18
@jerrykingxyz jerrykingxyz removed a link to an issue Feb 20, 2024
Rspress HMR is broken after enabling new tree shaking #5270
Closed
@jerrykingxyz jerrykingxyz merged commit 582fac6 into main Feb 20, 2024
17 checks passed
@jerrykingxyz jerrykingxyz deleted the jerry/update_module branch February 20, 2024 09:31
@IWANABETHATGUY
Copy link
Contributor

!canary

1 similar comment
@IWANABETHATGUY

This comment was marked as duplicate.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

0.5.4-canary-3e3c355-20240220100155

@colinaaa colinaaa mentioned this pull request Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

@jerrykingxyz jerrykingxyz

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: using concatenateModules with rspack serve cause runtime panic "should have build info"
2 participants
@jerrykingxyz @IWANABETHATGUY