-
-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(packages/rspack): add version check for binding #3717
feat(packages/rspack): add version check for binding #3717
Conversation
634cb42
to
4f9233b
Compare
4f9233b
to
2d0b12f
Compare
i think runtime check maybe better than postinstall check,postinstall causes problems in large monorepo,the postinstall costs a lot in monorepo if it has multi versions of rspack which we met when use esbuild in monorepo |
I think you are right, so where is the right place to put the check? When before createCompiler() , or before compiler build? |
e4d0e8a
to
4a37dd8
Compare
a030f34
to
b3a3c33
Compare
I am not sure we should check mismatch between core and binding or binding with binding-xx-yy,@h-a-n-a can you help check |
b3a3c33
to
1fd012a
Compare
@hardfist This change adds a boundary between raw binding output and the real user-end. So we can introduce a middle place for us to do some platform/arch mismatch diagnosis/error report. cc @lippzhang Note: rspack/packages/rspack/src/compiler.ts Line 10 in 8e73536
and load the binding lazily. Please deal with the error if any inconsistency happens. rspack/packages/rspack/src/compiler.ts Line 290 in 8e73536
This file is automatically generated by NAPI-RS. Please leave this file untouched. |
1fd012a
to
db4ff66
Compare
I can probably understand, but not sure, please help check it @h-a-n-a |
cc81131
to
268702c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The main point of lazily checking is to make sure directly importing
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
!eco-ci |
!canary |
0.2.8-canary-e979e23-20230720051633 |
* chore(packages/rspack): add version check for binding * feat: optimize version check * chore: cleanup * feat: optimize impl * fix: remote version check --------- Co-authored-by: Hana <[email protected]>
Summary
Add version consistency check for core, binding and addon.
closes #3715
Test Plan
ecosystem-ci passing