Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: better error report of tapable error #6051

Open
Tracked by #3459
hardfist opened this issue Mar 28, 2024 · 8 comments
Open
Tracked by #3459

[Feature]: better error report of tapable error #6051

hardfist opened this issue Mar 28, 2024 · 8 comments
Labels
contrib: medium feat New feature or request pr welcome stale team The issue/pr is created by the member of Rspack.

Comments

@hardfist
Copy link
Contributor

What problem does this feature solve?

It's kind of hard to read if rspack mets tapable error, and webpack seems do something to improve the error report
image

What does the proposed API of configuration look like?

no api need

@hardfist hardfist added feat New feature or request pending triage The issue/PR is currently untouched. labels Mar 28, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 28, 2024
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Mar 28, 2024

img_v3_029d_4f324f78-3d25-4a5c-8a24-65b1a9a804ag
Webpack error contains the error span information. Rspack should interop its error and make it better displayed.

@h-a-n-a h-a-n-a added contrib: medium pr welcome and removed pending triage The issue/PR is currently untouched. labels Mar 28, 2024
@h-a-n-a h-a-n-a removed their assignment Apr 26, 2024
Copy link

stale bot commented Jun 25, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Jun 25, 2024
@shulaoda
Copy link
Collaborator

Has this issue been resolved? Can I give it a try?

@stale stale bot removed the stale label Jul 23, 2024
@wxiaoyun
Copy link
Contributor

Has this issue been resolved? Can I give it a try?

It is not resolved. One potential improvement is that Rspack should show plugin name on error.

The miette diagnostic errors should be wrapped with the plugin name.

@hardfist
Copy link
Contributor Author

Has this issue been resolved? Can I give it a try?

Yeah give it a try

Copy link

stale bot commented Sep 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Sep 22, 2024
@shulaoda
Copy link
Collaborator

bump

@stale stale bot removed the stale label Sep 22, 2024
Copy link

stale bot commented Nov 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contrib: medium feat New feature or request pr welcome stale team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

No branches or pull requests

4 participants