Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when unsupported output.hashFunction method is used #4504

Closed
Tracked by #3459
uladzimirdev opened this issue Nov 1, 2023 · 0 comments · Fixed by #5129
Closed
Tracked by #3459

Improve error message when unsupported output.hashFunction method is used #4504

uladzimirdev opened this issue Nov 1, 2023 · 0 comments · Fixed by #5129
Labels
A-node-api Area: node api feat New feature or request good first issue Good for newcomers

Comments

@uladzimirdev
Copy link

What problem does this feature solve?

I got a cryptic error message:

thread '' panicked at 'not implemented: sha256', crates/rspack_hash/src/lib.rs:22:12

my config:

...
output: {
  ...,
  hashFunction: "sha256"
}

and it's completely valid for webpack, but not for rspack.

What does the proposed API of configuration look like?

It would be nice to print a list of supported methods instead.
As a workaround I used hashFunction: "xxhash64",

@uladzimirdev uladzimirdev added feat New feature or request pending triage The issue/PR is currently untouched. labels Nov 1, 2023
@hardfist hardfist added A-node-api Area: node api good first issue Good for newcomers and removed pending triage The issue/PR is currently untouched. labels Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-node-api Area: node api feat New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants