Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version check for binding #3715

Closed
Tracked by #3459
hardfist opened this issue Jul 6, 2023 · 2 comments · Fixed by #3717
Closed
Tracked by #3459

add version check for binding #3715

hardfist opened this issue Jul 6, 2023 · 2 comments · Fixed by #3717
Assignees
Labels
feat New feature or request good first issue Good for newcomers team The issue/pr is created by the member of Rspack.

Comments

@hardfist
Copy link
Contributor

hardfist commented Jul 6, 2023

What problem does this feature solve?

since we distribute @rspack/core and @rspack/binding separately, the version may mismatch here cause unexpected behavior here, we should do version check and provide nicely error message for users other than unreadable error message
image

What does the proposed API of configuration look like?

no api needed, esbuild provides nice error message for version check
image

@hardfist hardfist added feat New feature or request pending triage The issue/PR is currently untouched. feat: DX labels Jul 6, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jul 6, 2023
@hardfist hardfist added the good first issue Good for newcomers label Jul 6, 2023
@lippzhang
Copy link
Contributor

please assign this to me

@hardfist
Copy link
Contributor Author

hardfist commented Jul 6, 2023

thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request good first issue Good for newcomers team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants