Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking]: Diagnostics #3459

Open
15 of 17 tasks
h-a-n-a opened this issue Jun 7, 2023 · 4 comments
Open
15 of 17 tasks

[Tracking]: Diagnostics #3459

h-a-n-a opened this issue Jun 7, 2023 · 4 comments
Assignees
Labels
team The issue/pr is created by the member of Rspack. tracking issue Category: A tracking issue for an RFC or an unstable feature.

Comments

@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Jun 7, 2023

What subject does this issue tracking?

As time goes by, we have met some problems related to error handling. We want to improve the DX for both ourselves and our users.

Therefore, we plan to refactor the error-handling parts of Rspack in every aspect, these include, for example:

  • Better error diagnostics
  • Report the "how" and "why" when something breaks
  • Report when HMR is broken, it is currently silent

Tasks

  1. feat stale
    h-a-n-a
  2. feat stale team
  3. 16 of 16
    stale team
  4. feat feat: DX good first issue team
    lippzhang
  5. feat team
    hardfist
  6. feat stale team
  7. team
  8. team
    LingyuCoder
  9. bug need reproduction
    h-a-n-a
  10. A-node-api feat good first issue
  11. bug team
  12. A-resolver feat good first issue
    h-a-n-a
  13. 0 of 1
    tracking issue
  14. contrib: easy contrib: has guidance feat pr welcome team
    luhc228
  15. contrib: medium feat pr welcome stale team
  16. contrib: easy good first issue team
    luhc228
  17. contrib: medium feat pr welcome stale team
@h-a-n-a h-a-n-a added the tracking issue Category: A tracking issue for an RFC or an unstable feature. label Jun 7, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jun 7, 2023
@hyf0 hyf0 changed the title [Tracking]: Consistent error/warning report with webpack [Tracking]: Better error handling in Rspack Jun 26, 2023
@hyf0
Copy link
Collaborator

hyf0 commented Jun 26, 2023

Context:

This the current design of error-handling in Rspack: #548.

@hyf0
Copy link
Collaborator

hyf0 commented Jun 26, 2023

We should first design good error data structures both for the rust and js sides, then we could start to improve the error handling on top of those data structures.

@Boshen Boshen self-assigned this Jul 6, 2023
@h-a-n-a h-a-n-a assigned h-a-n-a and ahabhgk and unassigned Boshen Jul 24, 2023
@hardfist
Copy link
Contributor

hardfist commented Aug 2, 2023

need to add hint support for better error suggestions like webpack/webpack#17122, cc @ScriptedAlchemy

@hardfist
Copy link
Contributor

hardfist commented Aug 3, 2023

another thing drive me nuts is that when rspack panic all diagnostics is lost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack. tracking issue Category: A tracking issue for an RFC or an unstable feature.
Projects
None yet
Development

No branches or pull requests

5 participants