Misleading error message when request is ""

[IWANABETHATGUY]

System Info

system unrelated

Details

import {} from '';

rspack will throw error:

'should have context', crates/rspack_plugin_externals/src/plugin.rs:126:16

Reproduce link

No response

Reproduce Steps

1. npm create @rspack/cli@latest
2. change index.js to above
3. pnpm build

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

[hardfist]

bump

[Hamzakh777]

assign it to me @hardfist

[hardfist]

thanks

[Hamzakh777]

@hardfist it seems now the compiler is throwing a different error:

This is coming from this line: https://github.com/web-infra-dev/rspack/blob/main/crates/rspack_core/src/normal_module_factory.rs#L247
Should we use ModuleFactoryResult to return the error instead?

I believe this should be resolved somewhere in this file: https://github.com/web-infra-dev/rspack/blob/main/crates/rspack_plugin_javascript/src/dependency/esm/harmony_import_dependency.rs, let me know what you think?