Add support to route both GRPC and HTTP over the HTTP server #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
bboreham
reviewed
May 5, 2023
bboreham
reviewed
May 10, 2023
server/server.go
Outdated
Comment on lines
546
to
553
| if err == grpc.ErrServerStopped { | ||
| err = nil | ||
| } | ||
|
|
||
| select { | ||
| case errChan <- err: | ||
| default: | ||
| } |
There was a problem hiding this comment.
This is getting a bit repetitive - three exact copies of these 8 lines, plus two more of just the select.
Can I suggest extracting to a function?
Signed-off-by: Joe Elliott <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses https://github.com/soheilhy/cmux to provide the ability to route both HTTP and GRPC over the HTTP port with all of the GRPC server settings.
Currently it routes http1 to the http server and all http2 to the GRPC server.